(Previous discussion continued)
Fwd: [scheme-requests-for-implementation/srfi-121] fix overconsumption in generator->reverse-list, as in generator->list (#10) Arthur A. Gleckler 11 Aug 2016 02:21 UTC
Re: Fwd: [scheme-requests-for-implementation/srfi-121] fix overconsumption in generator->reverse-list, as in generator->list (#10) Jeremy Steward 11 Aug 2016 02:36 UTC

Re: Fwd: [scheme-requests-for-implementation/srfi-121] fix overconsumption in generator->reverse-list, as in generator->list (#10) Jeremy Steward 11 Aug 2016 02:36 UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

No objections here, this is better than my earlier fix, which was
naive as I tried to limit my changes to the code. Either way, I've
tested and it works. I'll pull changes in on my side as soon as you merg
e.

Cheers,

On 08/10/2016 08:21 PM, Arthur A. Gleckler wrote:
| Hello, authors of SRFI 121.  Do you approve of the bug fix by Kevin
| Wortman described below?  If so, I will publish it.
|
| Thanks, Kevin.
|
| kevinwortman <xxxxxx@github.com> writes:
|
| | Commit cd3f56f fixed a bug in generator->list, where the
| procedure | could consume the wrong number of elements from the
| generator. It | turns out that generator->reverse-list has the same
| bug. This patch | fixes that.
|>
| | While we're at it, we replaced each of these problematic loops
| with a | one-liner that reuses other procedures. The old loops were
| not | tail-recursive, so they allocated O(n) activation records.
| The new | code avoids that so should perform better.
|>
| |
| ----------------------------------------------------------------------
|>
|
|
| You can view, comment on, or merge this pull request online at:
|>
| |
| https://github.com/scheme-requests-for-implementation/srfi-121/pull/10
|>
|
|
| Commit Summary
|>
| | * fix overconsumption in generator->reverse-list, as in |
| generator->list
|>
| | File Changes
|>
| | * M generators/generators-impl.scm (28)
|>
| | Patch Links:
|>
| | *
| https://github.com/scheme-requests-for-implementation/srfi-121/pull/10
.patch
|>
|
|
| *
https://github.com/scheme-requests-for-implementation/srfi-121/pull/10.d
iff
|>
|>
| | — | You are receiving this because you are subscribed to this
| thread. | Reply to this email directly, view it on GitHub, or mute
| the thread.
|

- --
Jeremy Steward

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXq+S+AAoJEKflx7ZMcbY7Ke8P/jNw355Q0+YeQKm0MhXjyILD
9Bzru3ngFYkFOKLGLe2UIEV9fptP3Fa1jPRWkQNIdo/7o4DJZP5mTz8prMnixZO5
8O+Prvvc2s61WyNkRujYPhOn3v0GgV9O2lvfbDT8i0u4FEXFYB0hYPOFVvGryRwv
nsSboEIVIpZvpprIKo1HYeRjTwI7pjjl41LYD94Bt90fcq6jRkawj3bDs2Vcr/l/
A7XxILEsCeRwySU9HFfnSq7/jFTBKRybHYDnhWrJpLSdRsuOhqDJBrJRJO7RlSEs
e/CTqUB+4J6R4mU9LAUjesBaVxl17EPnrcxvq46id4MhJpFrqQTeNAYBZkFnAu0Q
98RQn7MiH45dKLzSbdI2P2W/eF/5uUmFL0pgXUPYd/leVzBJALBs2RHdEqM0U+Ir
HzdZ0jALGehjeVMcMqswGGfmqkb1ZJ/FJMuL4oPiLFTjUSkzLhZ6eW9/bdaOwxyy
oK7pTyIE8hCSJGBMrZOLLzsovt6iN5RD5es2uXQvOet8P51ndwybXqKUGJu8gyUa
qrcRvCKcd89epS4wocfDfU+CC4VO4s+E+F6lmeJZO01eYxuXgEmobukI08tSXAgO
/3ExlzLwaqUNj3whVIWWUzr/9pofSZPnkr+G/3R0PBrpSK5msq6i6PQuJbkXpEz0
yHOvOxMCijaOEpxSadby
=97Ik
-----END PGP SIGNATURE-----