On Thu, Oct 8, 2015 at 12:55 AM, Taylan Ulrich Bayırlı/Kammer <xxxxxx@gmail.com> wrote:
2. That environment variable is the easiest way to make hash tables
deterministic when running a test suite, and a 'getenv' call to get its
value and derive a salt from it doesn't seem like a big burden to me.
Using an environment variable is bad for a number of reasons:
It's non-portable to systems that don't support environment variables.
It's likely to be slow.
A parameter object seems like a much better way to supply this value. Implementations can decide how the default value for that parameter is set, and you could even suggest the environment variable, but it decouples things better.