comparator-register-default! is certainly trickly; the important part is "It is an error if any valueis satisfied ... " clause. With that, this procedure can only extend the default comparator butcan't alter its behavior in other ways (that is, calling it would make a piece of code run thatwould have thrown an error otherwise, but it wouldn't make a piece of code return differentresult.) Of course, it's a different matter how the implementation check the disjointnesscondition.I, too, had to read the spec several times to understand its implication. Would it be better tonote the fact?On Tue, Feb 9, 2016 at 3:24 PM, John Cowan <xxxxxx@mercury.ccil.org> wrote:Takashi Kato scripsit:
> - make-vector-comparator contains ']]' but no '[['. Seems not needed.
> - In description of comparator-if<=>, <object1 doesn't have >
> - comparator-if<=> doesn't say the comparison is done for given
> <object1> and <object2>.
> it is rather obvious in which order should be done but might be
> helpful to specify it.
> - Test case contains fake-hash-salt but no definition.
Fixed.
> - Should hash functions signal an error if given obj type does not
> match the type of function?
It can do that but is not required to.
> e.g. (boolean-hash 'a) ;; -> ?
It can return an exact integer or a random Scheme object, signal an
error, wipe your hard disk, or make demons fly out of your nose.
> - Should comparator-register-default! affect comparators already
> returned by make-default-comparator?
Again, it can do that but is not required to.
> - Default comparator of comparator-if<=>. Should comparator-if<=>
> evaluate (make-default-comparator) each time or it can be the same
> object?
It can be the same or different.
> - I'm implementing this SRFI atop SRFI-114 and it seems test case requires
> comparator-ordering-predicate to return the procedure passed to
> make-comparator.
> Is this required by the SRFI?
No. I have commented out those tests.
--
John Cowan http://www.ccil.org/~cowan xxxxxx@ccil.org
'Tis the Linux rebellion / Let coders take their place,
The Linux-nationale / Shall Microsoft outpace,
We can write better programs / Our CPUs won't stall,
So raise the penguin banner of / The Linux-nationale. --Greg Baker
To unsubscribe from this list please goto http://www.simplelists.com/confirm.php?u=yYPM36pIEQNxISBkdPrDJ2J6TsHkAgcm