Comments Takashi Kato (08 Feb 2016 12:01 UTC)
|
Re: Comments
John Cowan
(10 Feb 2016 01:24 UTC)
|
Re: Comments
Shiro Kawai
(10 Feb 2016 02:45 UTC)
|
Re: Comments
John Cowan
(15 Feb 2016 01:03 UTC)
|
Re: Comments
Shiro Kawai
(15 Feb 2016 01:04 UTC)
|
Re: Comments
Shiro Kawai
(15 Feb 2016 01:05 UTC)
|
Comments Takashi Kato 08 Feb 2016 12:01 UTC
Hi, I'm implementing SRFI-128 and got some trivial comments and questions. [Comments] - make-vector-comparator contains ']]' but no '[['. Seems not needed. - In description of comparator-if<=>, <object1 doesn't have > - comparator-if<=> doesn't say the comparison is done for given <object1> and <object2>. it is rather obvious in which order should be done but might be helpful to specify it. - Test case contains fake-hash-salt but no definition. [Questions] - Should hash functions signal an error if given obj type does not match the type of function? e.g. (boolean-hash 'a) ;; -> ? - Should comparator-register-default! affect comparators already returned by make-default-comparator? - Default comparator of comparator-if<=>. Should comparator-if<=> evaluate (make-default-comparator) each time or it can be the same object? - I'm implementing this SRFI atop SRFI-114 and it seems test case requires comparator-ordering-predicate to return the procedure passed to make-comparator. Is this required by the SRFI? Cheers, -- _/_/ Takashi Kato E-mail: ktakashi19@gmail.com