Hi, Kevin and John.  Would you please take a look at these proposed fixes for the sample implementation in SRFI 134?

I apologize, but I didn't forward them to you when they arrived in 2017.  I asked the original author to remove the extraneous indentation changes (to keep the commit small), but never heard back, and the change request fell off my radar.  I should have caught this long ago, and it may now require a merge.

Thanks.

---------- Forwarded message ---------
From: Peter Lane <xxxxxx@github.com>
Date: Wed, Jun 7, 2017 at 11:23 AM
Subject: [scheme-requests-for-implementation/srfi-134] corrected take/drop functions (#4)
To: scheme-requests-for-implementation/srfi-134 <xxxxxx@noreply.github.com>
Cc: Subscribed <xxxxxx@noreply.github.com>


Added test cases and code fixes for two errors:

  1. take/drop on complete size should be permitted
  2. %ideque-drop had an error in constructing size of adjusted ideque

You can view, comment on, or merge this pull request online at:

  https://github.com/scheme-requests-for-implementation/srfi-134/pull/4

Commit Summary

  • altered %check-length so take/drop work on whole ideque
  • fixed incorrect lenf in %ideque-drop

File Changes

Patch Links:

—