SRFI 134 draft 9 minor comments Sudarshan S Chawathe 04 Jun 2016 22:55 UTC

Here are some minor comments on draft 9 (2016/5/28) of SRFI 134.

  * Why is the equality test named "ideque=" instead of the more
    conventional (I think) "ideque=?" (as in char=?, string=?, ...)?
    I would be tempted to guess that the reasons are similar to those
    for 'member' but I couldn't figure out what would be returned as a
    "useful value" in this case.

  * It probably follows somehow from the description but perhaps, for
    greater clarity, the behavior of invoking ideque= on a single
    ideque could be specified explicitly.

  * Is there (or should there be) a guarantee that elt= will not be
	  invoked if ideque= is invoked with 0 or 1 ideque arguments?

  * (ideque-2list implementation) The implementations of ideque-take,
    ideque-take-right, ideque-drop, ideque-drop-right, and
    ideque-split-at report an error when these procedures are invoked
    with the 'n' argument equal to the length of the ideque.  (Based
    on a quick look at the code, it seems that the internal procedures
    are OK but the error-checking included in the API's wrapper
    procedures misses this case.)

  * ideque-zip: Is it correct that "number of elements involved"
    refers to the number of elements in the result (not the input
    ideques)?

Regards,

-chaw