Looks good to me. 

On Wed, Apr 3, 2019 at 11:44 AM Arthur A. Gleckler <xxxxxx@speechcode.com> wrote:
Thank you very much, Mr. Kawai.

John and/or Will, would you please review this pull request?  Since you're the authors, I'll wait for your approval before I merge it.

Thank you.

On Wed, Apr 3, 2019 at 2:22 AM Shiro Kawai <xxxxxx@gmail.com> wrote:
I just implemented srfi-144 in Gauche.  During testing using tests from the reference
implementations, I stumbled on some issues (those are issues in test code, not the spec).

* Some test data is desired to have more precision, which I created a PR.

* A couple of tests compared with exact match may yield 1ulp-off result computed
  in 64bit IEEE double precision throughout.  (It might not show if intermediate results
  is calculated in higher precision)
 -   (* 2 fl-1/sqrt-2)
 -   (fl* (flonum 1/3) (flonum 1/3) (flonum 1/3)), compared to (flonum (expt 1/3 3))

- Definition of flnormalized-fraction-exponent in the spec doesn't mention what if
  the argument is infinity.  The spec mentions C99 frexp, which returns +/-inf  as the
  fraction if the argument is +/-inf.  The reference implementation returns 0.5 as the
  normalized fraction, which does fits the description (0.5 <= abs(fraction)  < 1.0)
  but it also returns a finite exponent value which doesn't fit the description
  (although it is larger than the possible value).  So at best I read the behavior is
  undefined in spec.  The tests assume 0.5 is returned in such case.

To unsubscribe from this list please go to http://www.simplelists.com/confirm.php?u=L1OsVn7vrlnxb0ECqnMxrKaYv64BHIpQ