On Fri, Apr 21, 2017 at 2:45 PM, Jim Rees <xxxxxx@gmail.com> wrote:

(fleven? ix)   -- what's ix?  I infer a flonum with integer value, but
you didn't use the same parameter name in flodd?.

Fixed.
 
For fldenormalized,

issubnormal is not in C99.   Looks like it was put in to C11.

Presumably, this expression will suffice where issubnormal is not available?

(fpclassify(x) == FP_SUBNORMAL)

Fixed, and likewise for flnormalized.
 
In the spec for fl+* you refer to fl-fast-fl+*

..but in the spec for the constant, you spell it "fl-fast-+*"

Changed to fl-flast-fl+* for consistency.
 
Also, the users of this SRFI would be better able to make use of fl-fast-+*
if it were known at compile-time.    Would it make more sense to
suggest this symbol be in (features) when relevant?

This is an excellent point.  I have added it but mantain the variable as well as a fallback.
 
The constant fl-2/pi, you describe as bound to 2 ** fl-pi, but
I'm sure you meant 2 / fl-pi.

Fixed.
 
fl-greatest

fl-least

[snip]
 
Perhaps even clearer, "...the largest positive/negative finite flonums..."

Adopted.

In the definitions for fl-integer-exponent-zero and
fl-integer-exponent-nan, you refer to flinteger-binary-log which
doesn't exist anymore and can just be deleted.

Changed to refer to flinteger-exponent.
 
sign-bit -- did you intend to add this function without an fl-prefix?

Fixed.
 
The description of fllog10 is lacking a closing parenthesis.

Fixed.

Would you mind saying something about issues #1 (dyadic vs. variadic procedures) and #2 (fl+* vs. fl*+), if only to say that you have no opinion one way or another?  Thanks.

--
John Cowan          http://vrici.lojban.org/~cowan        xxxxxx@ccil.org
Historians aren't constantly confronted with people who carry on
self-confidently about the rule against adultery in the sixth amendment to
the Declamation of Independence, as written by Benjamin Hamilton. Computer
scientists aren't always having to correct people who make bold assertions
about the value of Objectivist Programming, as examplified in the HCNL
entities stored in Relaxational Databases.  --Mark Liberman