On Sat, Jun 17, 2017 at 11:58 PM, Arthur A. Gleckler <xxxxxx@speechcode.com> wrote:

Will Clinger has submitted this pull request for SRFI 144.  John, would you please take a look?  I would like to integrate it.

This is astouding, and of course you should integrate it at once.

Will, my only immediate comment is that I think it is better to implement the constants as literals, relying on Scheme's read-write invariance, rather than testing them against literals, which implicitly relies on the same thing.  In that way, less sophisticated compilers than Larceny can treat them as integrable constants involving no runtime computation, as is the case for their C analogues.  (Chicken, for example, can change the defines to use the Chicken-specific defining macro define-constant; see <http://wiki.call-cc.org/man/4/Non-standard%20macros%20and%20special%20forms#define-constant>.)  I'll be looking through the code in more detail soon.

If there aren't any issues with this contribution, I think we can move to last call quickly.  I noticed that the sign of gamma isn't well specified in the SRFI, and I'll change it to be so.

--
John Cowan          http://vrici.lojban.org/~cowan        xxxxxx@ccil.org
Here lies the Christian, judge, and poet Peter,
Who broke the laws of God and man and metre.