Re: Last call for comments on SRFI 228: Composing Comparators
Lassi Kortela 16 Nov 2022 12:03 UTC
> - make-product-comparator and make-sum-comparator are defined to take
> zero or more comparators. It'd be better that the behavior when no
> comparators are explicitly stated. Or we may define them to take at
> least one argument.
+1
> - I'm implementing srfi-228 for Gauche from the srfi text and find the
> description of above two procedures a bit confusing, because the
> elements of comparators (type test, equality, ordering and hashing)
> are all written in one paragraph. How about itemize each element?
+1
The names make-product-comparator and make-sum-comparator are quite
long. Could the "make-" prefix be dropped?
The terms "sum" and "product" are obtuse. I assume they refer to math
(category theory?), as in sum and product types. Are there everyday
words that would say something close enough? The description is also
hard to understand.
Anyway, the ability to compose comparators is a good one.