I've merged and pushed these changes.

Thank you, Bradley.

---------- Forwarded message ---------
From: Bradley Lucier
Date: Wed, Oct 4, 2023 at 3:29 PM
Subject: [scheme-requests-for-implementation/srfi-231] Improve tests (PR #49)

A bug in GCC (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64928) that prevented test coverage of generic-arrays.scm no longer presents in GCC 12.3 or later.

These changes were made after checking that test-arrays.scm exercises all of generic-arrays.scm.

generic-arrays.scm:

  1. In %%move-array-elements, remove a redundant test.

test-arrays.scm:

  1. make-interval: Test that it rejects intervals with a lower bound greater than an upper bound.

  2. interval-empty?: Test for error conditions, trivial unit tests.

  3. interval-fold-{left|right}: add non-error tests.

4: make-specialized-array: test two-argument version with an error in second argument.

  1. make-specialized-array-from-data: Add placeholder to test making mutable array from immutable data.

6: array-empty?: Add error and trivial unit tests.

7: %%move-array-elements: Add zero-dimensional arrays to tests. Fix reversed array tests.

8: array-outer-product: test specialized-arrays with > 4 dimensional arrays.

  1. array-{ref|set!}: Check error processing with > 4 dimensional arrays.

srfi-231.scm:

  1. Add line to generate link to commentary.

You can view, comment on, or merge this pull request online at:

  https://github.com/scheme-requests-for-implementation/srfi-231/pull/49

Commit Summary

File Changes

(3 files)

Message ID: <scheme-requests-for-implementation/srfi-231/pull/49@github.com>