Hi, Peter. Here are some of my comments on SRFI-278.

1. Both `exact-integer-nth-root` and `exact-integer-log` assume its 'k'
parameter to be an positive exact integer. Although these two procedures
will not return exact integers when k is not an exact positive integer,
it is still best to explicitly point this out.

2. A parameter of `rationalize` are named `delta-upper`, but you refer
to it later with another name `delta-higher`.

> This procedure is like rationalize in the R7RS. When delta-lower and
> delta-upper are specified, then the simplest rational between
> x−|delta-lower| and x+|delta-higher| [sic!] is returned.

3. The math formulae of `angle` are wrong. you wrote that

> where "angle⁡ z" is the phase of z=ae^(πθ) specified as
> angle ⁡z=θ+2⁢i⁢n

z=ae^(πθ) is wrong, it should be z=ae^(iθ) (the polar form of a
complex number).

Also, angle z=θ+2⁢i⁢n should be angle z=θ+2⁢πn (since when n ∈ N,
θ+2⁢πn is the same angle as θ)

4. In

> with n chosen such that −⁢π≤angle⁡ z≤π. When zero is unsigned, the
> principal expression for angle is −⁢π<angle ⁡z≤π.
>

The “z” in “angle z” is set in Roman typeface; to keep up with the
preceding text, these “z” should be set in italics.

--
Retrieve my PGP public key:
执行下列命令以获取我的 PGP 公有密钥：

  gpg --recv-keys B3EBC086AB0EBC0F45E0B4D433DB374BCEE4D9DC

Zihao / 閱卜錄