Re: Implementation suggestions Amirouche Boubekki 26 Jan 2020 11:48 UTC

Le dim. 26 janv. 2020 à 01:33, Lassi Kortela <xxxxxx@lassi.io> a écrit :
>
> This SRFI is so useful that I already started using the sample
> implementation even though it's work in progress :) I'd like to use it
> from more Scheme implementations than just Chibi.
>
> Do you accept the following changes?
>
> - Rename the library from (json) to (srfi 180)

Ok.

> - Rewrite `maybe-read-number` so it doesn't rely on regular expressions
> and `string->number`. This would remove the dependency on (chibi regexp)
> making it easier to port SRFI 180 to other R7RS Schemes.

chibi regexp is scheme regex (https://srfi.schemers.org/srfi-115/). I will put
that inside a cond-expand with a nop if it is not available.

> I can send a PR, or if you prefer to do them yourself, I'll wait. I
> already sent a PR with some trivial changes today; hope they're OK.

I will incorporate the changes in the next draft due later today or tomorrow.
Like I wrote in the other thread, I already changed some stuff and those changes
will end in a merge conflict I guess.

--
Amirouche ~ https://hyper.dev