New reference implementation
taylanbayirli@xxxxxx
(29 Aug 2015 17:38 UTC)
|
Re: New reference implementation
Per Bothner
(29 Aug 2015 20:23 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(29 Aug 2015 21:38 UTC)
|
Re: New reference implementation
Per Bothner
(30 Aug 2015 09:20 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(30 Aug 2015 10:45 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(31 Aug 2015 21:22 UTC)
|
Re: New reference implementation
Per Bothner
(31 Aug 2015 22:11 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(01 Sep 2015 08:44 UTC)
|
Re: New reference implementation
Per Bothner
(01 Sep 2015 10:44 UTC)
|
Re: New reference implementation
John Cowan
(30 Aug 2015 01:24 UTC)
|
Re: New reference implementation
Arthur A. Gleckler
(30 Aug 2015 04:35 UTC)
|
Re: New reference implementation
John Cowan
(30 Aug 2015 17:10 UTC)
|
Re: New reference implementation
Per Bothner
(30 Aug 2015 05:06 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(30 Aug 2015 08:06 UTC)
|
Re: New reference implementation
Per Bothner
(30 Aug 2015 08:25 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(30 Aug 2015 08:49 UTC)
|
Re: New reference implementation
Per Bothner
(30 Aug 2015 09:33 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(30 Aug 2015 12:35 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(22 Sep 2015 21:27 UTC)
|
Re: New reference implementation
Per Bothner
(24 Sep 2015 00:25 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(24 Sep 2015 08:26 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(26 Sep 2015 11:49 UTC)
|
Re: New reference implementation
Per Bothner
(28 Sep 2015 17:47 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(28 Sep 2015 19:54 UTC)
|
Re: New reference implementation
Per Bothner
(02 Oct 2015 06:07 UTC)
|
Re: New reference implementation
Per Bothner
(02 Oct 2015 06:36 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(02 Oct 2015 09:39 UTC)
|
Re: New reference implementation Per Bothner (06 Oct 2015 21:13 UTC)
|
Re: New reference implementation
taylanbayirli@xxxxxx
(07 Oct 2015 09:17 UTC)
|
I'm rather time-stressed until the end of this month, so I won't be able to fully evaluate this until then. One major difference I noticed: Consider (test-equal value expr). In your version the expr is wrapped in a lambda, and passed as a thunk. That has the advantage that the code size for the test-containing function is smaller, but the total code size is comparable - and on the JVM the generated .class files are slightly bigger. More importantly, you've changed evaluating an expression in-context to a procedure call. There will be lots more procedures, more call overhead, worse cache locality, and more pressure on closure allocation machinery. Probably more compilation time. I don't know if that's a good trade-off (I'll have to think about it), but I suspect not. (The more time it takes to run a test suite, the less frequently it will be run, which is not good.) > For simplicity, I'd like to keep the same format in stdout and the log file. Simplicity at the cost of a poor user experience is not a good tradeoff. You can do what you want of course. However, if I were to replace the existing implementation used by Kawa, I would make a number of changes, staring with more quiet terminal output. But as I said, I'll be able to spend more time on this in November. > Is it really useful to see the location of a passing test? One reason is if there is a crash or some other uncaught error. In that case it is useful to see how far we've got before the failure. >> That is very non-Unix-y. The traditional Unix philosophy is to say nothing >> on success, and a terse message on failure. I wouldn't go that far, >> but a simple: >> NNN expected passes >> is enough if all the expected tests pass (and no unexpected passes). > > It still keeps the user in silence during the run of a long test suite. That's ok. You're running a batch program. If I'm compiling a big program, I don't expect or want a lot of noise, either. > By the way source information for Kawa has been fixed too now, with help > of the tip you gave in the other mail. Yes, that seems fine. (Formatting issues aside, of course.) -- --Per Bothner xxxxxx@bothner.com http://per.bothner.com/