Re: Any more bugs/typos? Vladimir Nikishkin 16 Sep 2020 06:19 UTC

>Is the intention to make draw-bezier variadic

It is variadic, yes. You can supply 3 or more points.
A super-standard Bezier curve expects 4 points, a knot, two control
points, and another knot. If there are 3, the second one is also used
as the second control point.
You can actually supply more in the sample implementation, they will
be used to "enhance" the curve in some tricky way.

https://www.imagemagick.org/Usage/draw/

>Version control means they'll always be available.

I have deleted the commented-out functions.

>I've created a pull request for some commits fixing a few grammatical and formatting issues.  Nothing substantial.

I will merge it, and we can call it done, I guess.

On Wed, 16 Sep 2020 at 13:50, Wolfgang Corcoran-Mathe <xxxxxx@sigwinch.xyz> wrote:
>
> On 2020-09-16 09:54 +0800, Vladimir Nikishkin wrote:
> > Could people have another "last look"?
>
> I've created a pull request for some commits fixing a few grammatical
> and formatting issues.  Nothing substantial.
>
> Two remaining things that I noticed:
>
> (1) The form of draw-bezier is specified as
>
>     (draw-bezier . v-list)
>
> Is the intention to make draw-bezier variadic, or is the "dotted-tail
> notation" here a typo?
>
> (2) The sample implementation contains a lot of commented-out lines.
> I suggest deleting them.  Version control means they'll always be
> available.
>
> --
> Wolfgang Corcoran-Mathe  <xxxxxx@sigwinch.xyz>
>
> "Conquering the galaxy is what bacteria with spaceships would
> do--knowing no better, having no choice." --Greg Egan, _Disapora_

--
Yours sincerely, Vladimir Nikishkin